douangzhao4108
2018-06-02 16:29
浏览 85
已采纳

从递归函数返回数据?

I am slightly confused how do I refactor to return array data instead storing $this->data in the makeData() method.

For example:

private function makeData($cat, $itemCatId)
{
    $parentCat = $cat[$cat[$itemCatId]->parent_id];

     $this->data[] = $parentCat;

    if (!is_null($parentCat->parent_id)) {
        $this->makeData($cat, $parentCat->id);
    }
}

Usage

foreach($items as $item) {
 $this->data = []
 $this->makeData($cat, $item->id);

 // Then do something with `$this->data`
}

Then do something with $this->data

It seem this look like a code smell, in there a way to return data from makeData() when the Recursive is completed? For example:

foreach($items as $item) {
 $data = $this->makeData($cat, $item->id);

 // Then do something with `$data`
}

图片转代码服务由CSDN问答提供 功能建议

我有点困惑如何重构返回数组数据而不是存储 $ this-&gt; data < makeData()方法中的/ code>。

例如:

 私有函数makeData($  cat,$ itemCatId)
 {
 $ parentCat = $ cat [$ cat [$ itemCatId]  - &gt; parent_id]; 
 
 $ this-&gt; data [] = $ parentCat; 
 
 if(  !is_null($ parentCat-&gt; parent_id)){
 $ this-&gt; makeData($ cat,$ parentCat-&gt; id); 
} 
} 
   
  
 

用法

  foreach($ items as $ item){
 $ this-&gt; data = [] 
 $ this-&gt; makeData($  cat,$ item-&gt; id); 
 
 //然后用`$ this-&gt; data` 
}做一些事情
   
 
 

然后再做 $ this-&gt; data

看起来这看起来像代码味道,有一种从 makeData()<返回数据的方法 / code>当Recursive完成时? 例如:

  foreach($ items as $ item){
 $ data = $ this-&gt; makeData($ cat,$ item-&gt; id); \  n 
 //然后用`$ data` 
}做一些事情
   
 
  • 写回答
  • 好问题 提建议
  • 追加酬金
  • 关注问题
  • 收藏
  • 邀请回答

1条回答 默认 最新

  • douchen5971 2018-06-02 17:28
    已采纳

    You dont need recursion in this simple case. You can change point of reference in loop:

    function ancestors($data, $id) {
        $result = [];
        while ($id = $data[$id]->parent_id ?? false) {
            $result[] = $data[$id];
        }
        return $result;
    }
    

    Recursion would require dragging result and appending to it or array merging/unshifting (since its only one value at a time):

    function ancestors($data, $id) {
        $result = [];
        if ($id = $data[$id]->parent_id ?? false) {
            $result = parents($data, $id);
            array_unshift($result, $data[$id]);
        }
    
        return $result;
    }
    

    If reversed order doesn't bother you you might push $data[$id] to the end of recursively produced list as well.

    评论
    解决 无用
    打赏 举报

相关推荐 更多相似问题