dpitqpax07626 2013-06-26 11:56
浏览 28
已采纳

如何避免重复的代码?

I've the following Problem, those methods of my SQLBuilder are simply the same, what can I do to reduce the code?

    public function select($fields){
        if(is_array($fields)){
            $this->fields = implode(',', $fields);
        } else {
            $this->fields = $fields;
        } 
        return $this;
    }

    public function from($tables){
        if(is_array($tables)){
            $this->tables = implode(',', $tables);
        } else {
            $this->tables = $tables;
        } 
        return $this;
    }
  • 写回答

2条回答 默认 最新

  • douao3636 2013-06-26 12:19
    关注

    create a common private method that does the processing and then public methods that use them

    public function select($fields){
        return $this->builddata($fields, 'fields');
    }
    
    public function from($tables){
        return $this->builddata($tables, 'tables');
    }
    
    private function builddata($data, $storage) {
        if(is_array($data)){
            $data = implode(',', $data);
        }
        $this->$storage = $data; // variable variable
    
        return $this;
    }
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(1条)

报告相同问题?