从URL使用PHP到$ _GET [ID]

Question

i am using simple code to get some data from DB based on some unique ID called VIN. i wrote a script which work fine if somebody insert it in form, but now i need to edit to work more automaticly, and use $_GET['vin'] from URL and just display results based on that.

My try of code looks like: public $vin = null;

 public function __construct( $data = array() ) {
     if( isset( $data['vin'] ) ) $this->vin = stripslashes( strip_tags( $data['vin'] ) );
 }

 public function storeFormValues( $params ) {
    $this->__construct( $params ); 
 }

 public function fetchByVinEvidence($vin) {
     $success = false;
     try{
        $con = new PDO( DB_HOST, DB_USER, DB_PASS ); 
        $con->setAttribute( PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION );
        $sql = "SELECT * FROM evidence_vin WHERE vin = :vin LIMIT 1";
        $stmt = $con->prepare( $sql );
        $stmt->bindValue( "vin", $this->vin, PDO::PARAM_STR );
        $stmt->execute();
            echo "<table>";
            echo "<th>First Registration</th>";
            echo "<th>Validity Until</th>";
            echo "<th>Rpm</th>";
            echo "<th>Max-Speed</th>";
            echo "<th>Action</th>";
            while ($row = $stmt->fetch()){
                echo "<tr>";
                echo "<td>24</td>";
                echo "<td>".$row['claim_number']."</td>";
                echo "<td>".$row['license']."</td>";
                echo "<td>".$row['country']."</td>";
                echo "<td>".$row['vin']."</td>";
                echo "</tr>";
            }
            echo "</table>" ;
            }catch(PDOExeption $e){
            echo $e->getMessage();
            echo $con->errorInfo();
            }

         return $success;
     }

and call the function:

$vin = $_GET['vin'];
echo $vin;
$data = new Data;
$data->fetchByVinEvidence($vin);

Can somebody help me with that?

Answer 1

You pass a variable $vin to the function fetchByVinEvidence but then use the class level variable $this->vin instead of the passed one.

$stmt->bindValue( "vin", $this->vin, PDO::PARAM_STR );

should be

$stmt->bindValue( "vin", $vin, PDO::PARAM_STR );

OR set the class level variable to the passed one at the start of the function if you need to use it elsehwere:

public function fetchByVinEvidence($vin) {
     $this->vin = $vin;
     ....