PHPUnit和Guard子句，不是100％的覆盖率

Question

I have this Guard:

protected function validateRemove($key)
{
    if (!isset($this->collection[$key])) {
        throw new CategoryCollectionBadItemException();
    }
}

And the test:

/**
 * @test
 * @expectedException InfluenceDecision\Domain\Exception\Category\CategoryCollectionBadItemException
 */
public function removeMethodMustThrowExceptionWithInvalidKey()
{
    $this->categoryCollection->add(
        new Category(
            null,
            'test category'
        )
    );

    $this->categoryCollection->remove(1);
}

CategoryCollection remove method calls validateRemove method

The test works fine, but the coverage isn't 100% because the test can't access to the last line of validateRemove method:

What's the propper solution?

Answer 1

That's happening because you are not testing both the branches of the function, in your test case the function breaks when you throw the exception so it's not technically finishing. You have tested half of the function, even if it's the only logic in there.

If you want the 100% coverage, you need to create a test where $this->collection[$key] is set . In that case, I would suggest to change your function to something like

protected function validateRemove($key)
{
    if (!isset($this->collection[$key])) {
        throw new CategoryCollectionBadItemException();
    }

    return true;
}

and then create another test that asserts true when you call validateRemove() and $this->collection[$key] is set.

Mine is an example as I don't really know how do you use that piece of code!