douqin1932 2015-08-22 13:54
浏览 19
已采纳

有没有办法在PHP中更有效地做到这一点?

First of all, sorry for the title, I didn't know how to describe my problem.

I have the following piece of code (simplified).

if ($red && $italic)
    echo "<tr class='red italic'>";
elseif ($italic)
    echo "<tr class='italic'>";
elseif ($red)
    echo "<tr class='red'>";
else
    echo "<tr>";

Is there a way to simplify this, i.e. not use 8 lines? I know that's not very important but I was wondering if it could be possible.

Thanks!

  • 写回答

2条回答 默认 最新

  • donoworuq450547191 2015-08-22 13:59
    关注

    Yes, you can "simplify" it.

    echo '<tr' . ($red || $italic ? ' class="' . ($red ? 'red' : '') . ($italic ? ' italic' : '') . '"' : '') . '>';

    If you're not worried about sending an empty class, this can be shrunk:

    echo '<tr class="' . ($red ? 'red' : '') . ($italic ? ' italic' : '') . '">';

    You could write an entire app in one line if you wanted. But should you? Readability is extremely important.

    If you're looking to rewrite your code to make it look less repeated, there are loads of options.

    This method is the same number of lines as the original but allows you to easily add another class by changing one part

    $classes = array('red', 'italic');
    $used_classes = array();
    foreach ($classes as $class) {
        if ($$class) {
            $used_classes[] = $class;
        }
    }
    echo '<tr class="' . join(' ', $used_classes) . '">';
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(1条)

报告相同问题?

悬赏问题

  • ¥100 关于使用MATLAB中copularnd函数的问题
  • ¥20 在虚拟机的pycharm上
  • ¥15 jupyterthemes 设置完毕后没有效果
  • ¥15 matlab图像高斯低通滤波
  • ¥15 针对曲面部件的制孔路径规划,大家有什么思路吗
  • ¥15 钢筋实图交点识别,机器视觉代码
  • ¥15 如何在Linux系统中,但是在window系统上idea里面可以正常运行?(相关搜索:jar包)
  • ¥50 400g qsfp 光模块iphy方案
  • ¥15 两块ADC0804用proteus仿真时,出现异常
  • ¥15 关于风控系统,如何去选择