PHP：根据结果设置表格单元格背景

Question

I'm trying to generate colours based on output of a csv (originally formatted ping).

I can get the values no problem,but the if, ifelse, else doesn't seem to be working.

if($min > 0.499 && $min <= 1) {$tcolor = $yellow;} elseif($min >= 1.0) {$tcolor = $red; } else { $tcolor = $white;}
if($avg > 0.499 && $avg <= 1) {$tcolor = $yellow;} elseif($avg >= 1.0) {$tcolor = $red; } else { $tcolor = $white;}
if($max > 0.499 && $max <= 1) {$tcolor = $yellow;} elseif($max >= 1.0) {$tcolor = $red; } else { $tcolor = $white;}
if($mdev > 0.499 && $mdev <= 1) {$tcolor = $yellow;} elseif($mdev >= 1) {$tcolor = $red; } else { $tcolor = $white;}

echo "<tr><td>$ip</td><td bgcolor=\"$tcolor\">$min<br>$tcolor</td><td bgcolor=\"$tcolor\">$avg<br>$tcolor</td><td bgcolor=\"$tcolor\">$max<br>$tcolor</td><td bgcolor=\"$tcolor\">$mdev</td></tr>";

Edit: As many asked about the colour code already, I have it above the code listed as

$yellow = "#FFFF66";
$red = "#FF0000";
$white = "#FFFFFF";

And the number I see the overlap, but I've also tried with 0.999 with the same result.

Answer 1

It sounds like you got it solved, but you should look at using functions like so, so you don't have to repeat if statements like you did.

<?php

    function setCellColor($value){

        $color = '#FFFFFF';

        if($value >= 0.5 && $value <= 1){
            $color = '#FFFF00';
        } else if($value > 1) {
            $color = '#FF0000';
        }

        return ' style="background: ' . $color . '" ';
    }

    echo '<tr><td>' . $ip . '</td><td ' . setCellColor($min) . '>' . $min . '</td><td ' . setCellColor($avg) . '>' . $avg . '</td><td ' . setCellColor($max) . '>' . $max . '</td><td ' . setCellColor($mdev) . '>' . $mdev . '</td></tr>';

?>