尽管存在目标，Makefile规则始终执行

Question

I'm trying to adjust my Makefile for my GoLang project. I have several rules which should:

1. Setup a git pre-commit hook (Don't want to commit the binary files and break copyright law by accident)
2. Download an mp3 file via youtube-dl
3. Extract a subsection of that video via ffmpeg

Previously I was doing this via shellscript and checking for each file manually, but in the act of converting my script to a Makefile I seem to be missing something.

The only rule that doesn't re-run is the pre-hook, but I think that's because I'm not using a variable for my target/rule name?

.default: install
.phony: install generate clean

export bin_directory = bin
export asset_directory = data/assets
export song_url = https://www.youtube.com/watch?v=z8cgNLGnnK4
export song_file = ${bin_directory}/nsp-you-spin-me-cover.mp3
export loop_file = ${asset_directory}/spin-loop.mp3

install:
    go install .

generate: $(loop_file)
    go generate ./data

$(loop_file): $(song_file)
    mkdir -p "${asset_directory}"
    ffmpeg -i "${song_file}" -ss 00:01:13.30 -to 00:01:30.38 -c copy "${loop_file}"

$(song_file): .git/hooks/pre-commit
    mkdir -p "${bin_directory}"
    youtube-dl "${song_url}" --extract-audio --audio-format mp3 --exec "mv {} ${song_file}"

.git/hooks/pre-commit:
    cp ./pre-commit .git/hooks/pre-commit
    chmod +x .git/hooks/pre-commit

clean:
    git clean -xdf

UPDATE: I've found this works correctly if I lump all the dependencies onto the generate rule like so (which seems like the wrong thing to do)

.default: install
.phony: install generate clean

bin_directory:=bin
asset_directory:=data/assets
song_url:=https://www.youtube.com/watch?v=z8cgNLGnnK4
song_file:=$(bin_directory)/nsp-you-spin-me-cover.mp3
loop_file:=$(asset_directory)/spin-loop.mp3

install:
    go install .

.git/hooks/pre-commit:
    cp ./pre-commit .git/hooks/pre-commit
    chmod +x .git/hooks/pre-commit

$(song_file):
    mkdir -p "${bin_directory}"
    youtube-dl "${song_url}" --extract-audio --audio-format mp3 --exec "mv {} ${song_file}"

$(loop_file):
    mkdir -p "${asset_directory}"
    ffmpeg -i "${song_file}" -ss 00:01:13.30 -to 00:01:30.38 -c copy "${loop_file}"

generate: .git/hooks/pre-commit $(song_file) $(loop_file)
    go generate ./data

clean:
    git clean -xdf

Answer 1

You don't specify but I assume you're running make generate when you see this behavior. It's always best when asking questions if you show the command you typed, the output you got (cut and paste and formatted properly) or at least sufficient of it to see the problem, and point out exactly which part of the output is unexpected AND what you expected to happen instead.

Assuming your environment and makefile are accurately described above, then the most obvious cause of the behavior you're seeing is that this command:

youtube-dl "${song_url}" --extract-audio --audio-format mp3 --exec "mv {} ${song_file}"

is not updating the timestamp on the output file $(song_file), so it always looks older than the targets that depend on it, so make always rebuilds it.

After you run your makefile, use ls -l on all the expected output files and see if their modification times are updated. If not you may need to add touch $@ to your rule after the youtube-dl command, to make sure it was updated:

$(song_file): .git/hooks/pre-commit
        mkdir -p "${@D}"
        youtube-dl "${song_url}" --extract-audio --audio-format mp3 --exec "mv {} $@"
        touch $@

Also as mentioned in the comments above, and as described in the GNU make documentation, the special targets are .DEFAULT (uppercase) and .PHONY (uppercase), not .default and .phony. Those latter are simply targets you've defined, just like foo or whatever; they have no special meaning to GNU make. makefiles, like all UNIX/POSIX tools and languages, are case-sensitive so be careful to use the correct case for keywords as described in the GNU make manual (and for the targets you define in your makefile)

Removing the export won't change anything: GNU make allows a variable to be assigned and exported on the same line.