优雅的方式来计算多个模型并将变量携带到视图中 - laravel

Question

I am cleaning up my code which I wrote as a hopeless noob.

I am creating a view with user statistics. My intention is to make a table showing both site and user stats, for instance:

Our repository has **1000** quotes **120** of them are contributed by you.

I have several models such as Book, Quotation, Excerpt etc. To display the above, I define in my controller multipe variables

$userCountQuotes = count(Quote::where('creator_id','=',$userid)->get());
$CountQuotes = count(Quote::get());

and then pass them this way

return View::make('userworkspace.stats', compact('userCountQuotes','CountQuotes'))

I have about 10 different models to serve - 20 variables. Is there a more elegant way to get the numbers and display them in view?

My own solution: create a two-dimensional array of values

$stats= array
(
array("Books",22,18),
array("Quotes",15,13)
...
);

and then I have only one variable to pass to my view. Is that elegant enough? Any better ideas?

Answer 1

@lukasgeiter's answer is good, but I prefer another way which I'll add here as well.

Personally, I would make a method to get the count either within the model or a repository. I'd go the other way around for the $userCountQuotes - that is, starting with the user rather than with the quotes - and I'd use the built-in functionality for it.

Here's an example, which assumes that the models are properly related. In the User model:

public function quotesCount()
{
    return $this->quotes()->count();
}

And in the Quote model:

public static function countAll()
{
    return static::all()->count();
}

Then, in the view, pass the user and do this:

Our repository has **{{ Quote::countAll() }}** quotes - **{{ $user->quotesCount() }}** of them are contributed by you.