在foreach成功之后处理php错误

Question

I tried catch if do CRUD in foreach loop, if success loop finish push message into array, below is my function, I push message after foreach is it correct?

// .. defined response_message array

try {
  foreach ($data as $i => $each_data) {
    $sql = "UPDATE tag_0 SET sequence = :sequence WHERE id = :id";
    $stmt = $connect_db_read->prepare($sql);
    $stmt->bindValue(':id', $each_data['id']);
    $stmt->bindValue(':sequence', $each_data['sequence']);
    $stmt->execute();
  }

  // here
  $success_message = 'success_message: store in database success';
  array_push($response_message['success_message'], $success_message);
} catch (PDOException $e) {
  $debug_message = $e->getMessage();
  array_push($response_message['debug_message'], $debug_message);
  $error_message = "error_message: ? database";
  array_push($response_message['error_message'], $error_message);
}


$data = array();
$data['response_message'] = $response_message;


return $data;

Answer 1

$stmt->execute(); will return true when a query is succesful.

This does not mean the record was updated , it only means that the query executed without error.

To be really sure, you have to check the number of affected rows using rowCount()

Try this approach:

$error_counter = 0;
$sql = "UPDATE tag_0 SET sequence = :sequence WHERE id = :id";
$stmt = $connect_db_read->prepare($sql);  
foreach ($data as $i => $each_data) {
    $stmt->bindValue(':id', $each_data['id']);
    $stmt->bindValue(':sequence', $each_data['sequence']);
    $status = $stmt->execute();
    $row_count = $stmt->rowCount();
    if($status && $row_count > 0){
        $success_message = 'Successful update for sequence id ='.$each_data['id'];
        array_push($response_message['success_message'], $success_message);
    }else{
        $failed_message = 'update failed for sequence id ='.$each_data['id'];
        array_push($response_message['fail_message'], $fail_message);
        $error_counter++;
    }
}

You should also prepare once than bind and execute in the loop, no need to send the query back to the db at each iteration.

---

I added another way to track with a variable $error_counter if the value is 0 then all records where updated.

//check after the loop
if($error_counter === 0){
    echo 'All UPDATES SUCCESSED !!!!';
}else{
    echo 'NOT ALL SUCCESFUL !';
}

Alternatively you can achieve the same using the count of the failed messages:

(count($response_message['fail_message'])===0)