是否应该以这种方式使用switch语句？ [关闭]

Question

Is it acceptable to use a switch as a way of supporting multiple file formats, or is it bad practice?

Like so (untested):

<?php

    // Load file
    switch ($data_format) {
        case 'xml':
            $openfile = simplexml_load_file($filename . '.xml');
            break;

        case 'json':
            $openfile = json_decode(file_get_contents($filename . '.json'));
            break;
    }

    // Do stuff

    // Save file
    switch ($data_format) {
        case 'xml':
            $openfile->asXML($filename . '.xml');
            break;

        case 'json':
            file_put_contents($filename . '.json', json_encode($openfile, JSON_PRETTY_PRINT));
            break;
    }

?>

Answer 1

It depends on your style of coding. If you want to work object oriented then this would be against the idea. In this case you'd use something like:

$file = $repository->open($filename, $data_format);
// do stuff
$file->save();

Of course $repository->open() needs to return an object with a different save method depending on your data format.

However if you are not working object oriented but good old procedural style I cannot see anything wrong with your use of the switch statement.