PHP无法从对象回显用户的名称

Question

I'm trying to use a session var and call the logged in users details through object on the page. The user has already logged in through my login object. Here are my objects:

class User {
   public $userdata = array();


//instantiate The User Class
   public function User(){  }

public function set($var, $value) {
    $this->userdata[$var] = $value; 
}

public function get($var) {
    if(isset($this->userdata[$var]))
    {
        return $this->userdata[$var];
    }
    return NULL;
}

  function __destruct() {
    if($this->userdata){
       $this->userdata;
    }
  } 
}

class UserService {
private $db;
private $fields;
public $user;
private $session;


    public function __construct() {
        $this->db = new Database();

    }



//  //get current user by ID
    public function getCurrentUser($session) {

            $this->session = $session;

        $query = sprintf("SELECT * FROM User WHERE idUser=%s",
        $this->db->GetSQLValueString($this->session, "int"));
        $result = $this->db->query($query);

         if($result && $this->db->num_rows($result) > 0){

            //create new user
                $user = new User();
                $row = $this->db->fetch_assoc($result);

            //set as object
            foreach($row as $key => $value) {
                $user->set($key, $value);

                break;
            }
            return $user;
            //return $this->user;

        }
        return NULL;    


    }
 }

On my page I've check my session var has a value which it does, so I call the object like so.

 $um = new UserService();
 $user = $um->getCurrentUser($_SESSION['MM_Username']);
 echo $user->get('UserSurname');

however, I see no user surname on the page. I have checked with a none object query and I see a surname but as soon as its object is doesn't work.

Answer 1

I think the problem is here:

foreach($row as $key => $value) {
                $user->set($key, $value);

                break; // you should probably remove it
            }

You should use unnecessary break and probably after setting for example id you stop setting another object properties (UserSurname, Name and so on).

In addition it's quite confusing that inside $_SESSION['MM_Username'] you store idUser and not UserName