PHP嵌套if语句 - 有更好的方法吗？

Question

Could I nest these PHP IFs in a better to understand/ more logical way?

 if (isset($_GET['numberofwelds']) && isset($_GET['numberofconwelds']))
    {
        $numwelds = $_GET['numberofwelds'];
        $numconwelds = $_GET['numberofconwelds'];

        if (is_int($numwelds) && is_int($numconwelds))
        {
            $total = $numwelds + $numconwelds;
            $response = json_encode($total);
            header(“Content-Type:application/json”);  
            echo $response;
            exit;
        }
    }

Answer 1

You can use ternary statements to make this a little bit nicer. The logic is the same, but you can reduce the number of lines required, at the expense of a little readability.

Some other important points to note:

• You had smart quotes. “ is not the same as ". The former will not be parsed by PHP -- and will most likely throw an Internal Server Error.

• Don't use is_int() — it will lie to you. When you're working with user input data, you'll be fetching it from $_POST, $_GET superglobal arrays. All those values will be stored as strings. is_int() treats a string containing a number, for e.g., "42" as as a string, and will return false. Use is_numeric() instead.

Updated code:

$numwelds = isset($_GET['numberofwelds']) ? $_GET['numberofwelds'] : '';
$numconwelds = isset($_GET['numberofconwelds']) ? $_GET['numberofconwelds'] : '';

if (is_numeric($numwelds) && is_numeric($numconwelds))
{
    $total = $numwelds + $numconwelds;
    $response = json_encode($total);
    header("Content-Type: application/json");  
    echo $response;
    exit;
}