You are correct. I'm not sure if this is bug ( but as the functionality wise this should be bug ).
So the difference between 1.6 ( and older version ) / and 1.7 is:
The Model
Mage_Sales_Model_Order
Has This method
protected function _getItemsRandomCollection($limit, $nonChildrenOnly = false){
$(...)->setVisibility(Mage::getSingleton('catalog/product_visibility')->getVisibleInSiteIds()) // This is Visibility check ( its fine )
foreach ($collection as $item) {
$product = $productsCollection->getItemById($item->getProductId());
if ($product) {
$item->setProduct($product); // Set Object Data ( 'product' ) if it exists
}
}
}
So In the previous code the last ordered item collection has property called 'product' that hold the product object if its returned and its not set if its not returned.
The above code is fine and works no issues in it.
In Model
Mage_Sales_Block_Reorder_Sidebar
The getItems Method is :
/**
* Get list of last ordered products
*
* @return array
*/
public function getItems()
{
$items = array();
$order = $this->getLastOrder();
$limit = 5;
if ($order) {
$website = Mage::app()->getStore()->getWebsiteId();
foreach ($order->getParentItemsRandomCollection($limit) as $item) {
if ($item->getProduct() && in_array($website, $item->getProduct()->getWebsiteIds())) {
$items[] = $item;
}
}
}
return $items;
}
=================================================================================
In Magento 1.6 and prior versions
When you call $item->getProduct(); in sidebar block,
it will return the object property ( Mage_Catalog_Model_Product - product instance - ) that has been set in the method above ( _getItemsRandomCollection() )
OR it will return NULL if not set.
So if it returns Product object the item will be shown in the sidebar block and if not the return array will not contain that Virtual Item
=================================================================================
In Magento 1.7
When you call $item->getProduct(); in sidebar block,
===>> This method is implemented in the model
Mage_Sales_Model_Order_Item
When you call the method it will be executed from the model ( it won't lookup for object property ).
So if you take a look at the method implementation
/**
* Retrieve product
*
* @return Mage_Catalog_Model_Product
*/
public function getProduct()
{
if (!$this->getData('product')) { // If no object attribute set with name ('product')
$product = Mage::getModel('catalog/product')->load($this->getProductId()); // it will always return product instance with that product id.
$this->setProduct($product); // set it to the current sidebar item
}
return $this->getData('product'); // return the object property 'product'
}
So In the case if the method ( _getItemsRandomCollection() ) didn't set the object property 'product' because its not visible or something ( This method will assign it by product ID directly without checking for visibility or anything else.
Yes I consider this a bug and it need to be fixed
That was the answer for the reason why
=================================================================================
The solution is pretty simple
1.Create custom module.
2.Extend/Rewrite the Model.
Mage_Sales_Model_Order_Item
3.Override the method and ( Comment the code Block) or add The visibility check in the method.
Solution 1 ( comment the code block that set the item product ).
/**
* Retrieve product
*
* @return Mage_Catalog_Model_Product
*/
public function getProduct()
{
/** comment from here
*if (!$this->getData('product')) {
* $product = Mage::getModel('catalog/product')->load($this->getProductId());
* $this->setProduct($product);
*}
* Till here.
*/
return $this->getData('product');
}
OR
Solution 2 : Add the visibility check to the method as below.
/**
* Retrieve product
*
* @return Mage_Catalog_Model_Product
*/
public function getProduct()
{
if (!$this->getData('product')) {
$product = Mage::getModel('catalog/product')->load($this->getProductId());
if(!$product->isVisibleInSiteVisibility()) // add visibility check here
{
$this->setProduct($product);
}
}
return $this->getData('product');
}
I have spent some time doing this :) hope it helps you !
