dq_1984 2013-12-17 22:31
浏览 27
已采纳

MySQLi更新查询不起作用 - 没有错误?

I'm trying to figure out why on earth the query below isn't working. Basically it checks if a checkbox is checked, if it is the checkboxes relating variable and therefore mysql record is set to 1. If the checkbox isn't checked its set to 0. I've added multiple different troubleshooting and error reporting snippets - no errors. Yet no success? This is driving me mad. Any advice is warmly welcomed! Thank you.

if(isset($_POST['updateUser'])){

$mysqli = mysqli_connect($config['host'], 
                         $config['user'], 
                         $config['pass'], 
                         $config['db']);

foreach($_POST as $k => $v) {
    $check[$k] = isset($_POST[$k]) ? 1 : 0;
} 

$query = "UPDATE users_permissions SET editComments = ?, 
                                       editTopics = ?, 
                                       editArticles = ?, 
                                       autoApprove = ?, 
                                       allowArticleMod = ?, 
                                       courseAuthor = ?, 
                                       seeFinance = ?, 
                                       editUsers = ?, 
                                       editUsersPermissions = ?, 
                                       editSuperUsers = ?,
                                       editWL = ?
                                   WHERE 
                                       userid = ?";

$stmt = $mysqli->prepare($query);
$stmt->bind_param('iiiiiiiiiiii',                                                                                         

                                  $check['editComments'],
                                  $check['editTopics'],
                                  $check['editArticles'],
                                  $check['autoApprove'],
                                  $check['allowArticleMod'],
                                  $check['courseAuthor'],
                                  $check['seeFinance'],
                                  $check['editUsers'],
                                  $check['editUsersPermissions'],
                                  $check['editSuperUsers'],
                                  $check['editWL'],
                                  $profileData['userid']);
                                  $profileData['userid']);

$stmt->execute();

}

UPDATED: Changes made to code to reflect suggestion made by @Floris

  • 写回答

1条回答 默认 最新

  • dongpiao8821 2013-12-17 22:42
    关注

    I'm sorry but those if-blocks hurt my eyes. I know it's not really "the" answer but you should do this instead:

    $checks = [];
    foreach($_POST as $k => $v) {
        $checks[$k] = isset($_POST[$k]) ? 1 : 0;
    }
    

    Now you have an array called $checks which has all the $_POST keys as you had before with a 0/1 value depending on whether it was set, and you skip a whole bunch of ugly code! Yay! Now, just replace the bind_param vars with $check vars.

    EDIT - More code, with comments:

    //Go through each variable in the $_POST array, using "$k" to refer to the key and "$v" to the value,
    //So, $_POST["editComments"] = "foo" would have $k = "editComments" and $v = "foo"
    foreach($_POST as $k => $v) {
        //This is a shorthand if-statement which basically means: if isset($_POST[$k]) == true, $checks[$k] = 1. Else, $checks[$k] = 0.
        $checks[$k] = isset($_POST[$k]) ? 1 : 0;
    }
    
    //Nothing new here
    $query = "UPDATE users_permissions SET editComments = ?, 
                                       editTopics = ?, 
                                       editArticles = ?, 
                                       autoApprove = ?, 
                                       allowArticleMod = ?, 
                                       courseAuthor = ?, 
                                       seeFinance = ?, 
                                       editUsers = ?, 
                                       editUsersPermissions = ?, 
                                       editSuperUsers = ?,
                                       editWL = ?
                                   WHERE 
                                       userid = ?";
    
    $stmt = $mysqli->prepare($query);
    
    //So here's how to bind the $checks variables:
    $stmt->bind_param('iiiiiiiiiiii', $checks["editComments"],
                                      $checks["editTopics"], //and so on
                                      $editArticles,
                                      $autoApprove,
                                      $allowArticleMod,
                                      $courseAuthor,
                                      $seeFinance,
                                      $editUsers,
                                      $editUsersPermissions,
                                      $editSuperUsers,
                                      $editWL,
                                      $profileData['userid']);
    
    $stmt->execute();
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥60 pb数据库修改或者求完整pb库存系统,需为pb自带数据库
  • ¥15 spss统计中二分类变量和有序变量的相关性分析可以用kendall相关分析吗?
  • ¥15 拟通过pc下指令到安卓系统,如果追求响应速度,尽可能无延迟,是不是用安卓模拟器会优于实体的安卓手机?如果是,可以快多少毫秒?
  • ¥20 神经网络Sequential name=sequential, built=False
  • ¥16 Qphython 用xlrd读取excel报错
  • ¥15 单片机学习顺序问题!!
  • ¥15 ikuai客户端多拨vpn,重启总是有个别重拨不上
  • ¥20 关于#anlogic#sdram#的问题,如何解决?(关键词-performance)
  • ¥15 相敏解调 matlab
  • ¥15 求lingo代码和思路