如何缩短这个设定值检查？

Question

This is my first post. I hope I'm doing this right. I have written this little piece of code, it checks some request parameters. Has anyone a clue how to write this in a shorter and maybe better performance way?

$request = $_REQUEST;
if ( isset($request['customerId']) && 
    ! $request['customerId']  == '' && 
     isset($request['subscriptionId']) && 
     ! $request['subscriptionId']  == '' && 
     isset($request['customer_ext_uid']) && 
     ! $request['customer_ext_uid']  == '' && 
     isset($request['referrer']) && 
     ! $request['referrer']  == '' && 
     $request['referrer']  == 'fastbill' || 
     $request['referrer']  == 'paypal' && 
     $request['do']  == 'success' && 
     $request['do']  == 'success' ) :
    echo "good";
else :
    echo "bad";
endif;

In the end the success URL should look like this:

https://DOMAIN/?customerId=12347&customer_ext_uid=12347&subscriptionId=12347&referrer=paypal&do=success

Thanks in advance!

Answer 1

One way to do it could be like this, it'll also make it easier to add more checks in the future, and / or reuse it.

$required = array('customerID','subscriptionId'); //Fill in the fields you want checked
$request = $_REQUEST;

function allOk($required,$request){
    foreach($required as $key){
        if(empty($request[$key])){
            return FALSE;
            die();
        }
    }

    if($request['do'] != 'success' || ($request['referrer'] != 'fastbill' && $request['referrer'] != 'paypal')){
        return FALSE;
        die();
    }

    return TRUE;
}

And then you can either use a if sentence or a ternary operator, depending how much action you want according to the result.

if(allOk($required,$request)){
   echo "good!";
}else{
   echo "BAD!";
}

Ternary operator:

echo (allOk($required,$request)) ? 'good' : 'bad' ;