dqm74406 2016-11-02 11:44
浏览 152
已采纳

Golang测试,调用数据库Prepare应该失败,但不会失败

I'm writing some test code with the help of go sqlmock.

The following code does not validates if the prepared statement has the correct query.

The main code is this:

// main.go
package main

import "database/sql"

func testFunction(db *sql.DB) {
    db.Prepare("SELECT")
}

func main() {}

And the test code:

// main_test.go
package main

import (
    "testing"

    "github.com/stretchr/testify/assert"
    sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
)

func TestPrepare(t *testing.T) {
    db, mock, mErr := sqlmock.New()
    assert.NoError(t, mErr)
    defer db.Close()

    mock.ExpectPrepare("^BADSELECT$")

    testFunction(db)

    if err := mock.ExpectationsWereMet(); err != nil {
        t.Errorf("there were unfulfilled expections: %s", err)
    }

}

As far as i know, the test should fail, but it does't. What i'm i doing wrong? I'm using GO 1.7/macOS 10.12.1.

Thanks

  • 写回答

1条回答 默认 最新

  • dougu7546 2016-11-02 12:27
    关注

    Answering my own question,

    Calling ExpectPrepare() returns a ExpectPrepare struct. In order to assert that Prepare() is being called with the right query, on must use ExpectQuery on the struct. See the example bellow.

    package main
    
    import (
        "database/sql"
        "fmt"
    )
    
    func testFunction(db *sql.DB) {
        stmt, err := db.Prepare("SELECT")
        if err != nil {
            fmt.Println(err)
    }
    
        stmt.Query()
    
    }
    
    func main() {}
    
    package main
    
    import (
        "testing"
    
        "github.com/stretchr/testify/assert"
        sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
    )
    
    func TestPrepare(t *testing.T) {
        db, mock, mErr := sqlmock.New()
        assert.NoError(t, mErr)
        defer db.Close()
    
        mock.ExpectPrepare("^SELECT$").ExpectQuery()
    
       testFunction(db)
    
        if err := mock.ExpectationsWereMet(); err != nil {
            t.Errorf("there were unfulfilled expections: %s", err)
        }
    
    }
    

    EDIT:

    After reporting an issue, it turns out this was actually a BUG in the go-sqlmock package. It's fixed. We should now be able to use ExpectPrepare(). go-sqlmock issue #50

    Thanks

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥50 wordpress项目注册报失败刷新后其实是成功状态,请求排查原因
  • ¥20 linxu服务器僵尸进程不释放,代码如何修改?
  • ¥15 pycharm激活不成功
  • ¥40 如果update 一个列名为参数的value
  • ¥15 基于51单片机的水位检测系统设计中LCD1602一直不显示
  • ¥15 OCS2安装出现问题,请大家给点意见
  • ¥15 ros小车启动launch文件报错
  • ¥15 vs2015到期想登陆但是登陆不上
  • ¥15 IPQ5018制作烧录固件,boot运行失败(操作系统-linux)(相关搜索:操作系统)(相关搜索:操作系统)
  • ¥20 icefall在librispeech基础上加入个人数据集