2019-03-21 14:23
浏览 98


I have a question about golangci-lint. The linter returns me for something like:

type outputFormat string

const (
    formatNone outputFormat = ""
    formatText              = "TEXT"
    formatJSON              = "JSON"

an error like:

only the first constant in this group has an explicit type (staticcheck)
formatNone outputFormat = ""

But what's the problem about it? In https://go101.org/article/constants-and-variables.html they describe in chapter Autocomplete in constant declarations that incomplete constants will be recognized and filled.

I did not find any reference which tells me to avoid using incomplete constant definitions.

Can somebody explain to me, what's the matter behind that?

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 邀请回答

1条回答 默认 最新

  • douxing5199
    douxing5199 2019-03-21 14:26

    As explained in staticcheck's documentation for that check:

    In a constant declaration such as the following:

    const (
         First byte = 1
         Second     = 2

    the constant Second does not have the same type as the constant First. This construct shouldn't be confused with

    const (
          First byte = iota

    where First and Second do indeed have the same type. The type is only passed on when no explicit value is assigned to the constant.

    When declaring enumerations with explicit values it is therefore important not to write

    const (
          EnumFirst EnumType = 1
          EnumSecond         = 2
          EnumThird          = 3

    This discrepancy in types can cause various confusing behaviors and bugs.

    点赞 评论