使用数组内爆来构建插入查询

Question

I am following tutorials for user registration. This is what I am trying to build query using implode:

if(isset($_POST['submit'])){
                $registration_data= array(
                    'username'      =>   $_POST['username'], 
                    'password'      =>   $_POST['password'], 
                    'password_again' =>   $_POST['password_again'], 
                    'first_name'    =>   $_POST['first_name'], 
                    'last_name'     =>   $_POST['last_name'],
                    'email'         =>   $_POST['email']
                );     

                register_user($registration_data);

        }

function register_user($registration_data){
        global $connect; 
        $data=implode(',', $registration_data).'}';
        $fields= implode(",", array_keys($registration_data));

Now I have to build query like this

$query=INSERT INTO users ($fields) VALUES($data);

//  I want data to be formated like this '{$username}', '{$password}', 

How can I do it in above mentioned implode functions,

Note: I am just following some basic tutorials so not worried about PDO/ injections etc

Answer 1

You need to put quotes around all the data values before you implode them:

$data = implode(',', array_map(function($x) {
    return "'" . $x . "'";
}, $registration_data));
$fields = implode(',', array_keys($registration_data));
$query = "INSERT INTO users ($fields) VALUES ($data)";