在编程中使用'hacks'？

Question

I have this example pseudo-code that works, $x basically is an object with keys and values or array with keys and objects as values. $y will be constructed in two different ways.

private function someFunction($x) {
    if (is_object($x)) {
        $y = 'result of something';
    } elseif (is_array($x)) {
        $y = 'result of something';
    } else {
        $y = null;
    }

    return $y;
}

Is this a good practice, if function will not be used anywhere else? 'Non-hack' way probably is to convert object to an array (because it is an array in essence) and then make logic based on count of arrays.

Or am I just thinking to much about writing code 'right way'?

Answer 1

The way of using this function is acceptable as long as the input is controlled by you and you know what you are going to do with the data. However on inputs from uncontrolled sources from outside, you should validate the data beforehand as you would not know for sure if the data is valid.

What I don't understand is how you reach a point a variable may be two different types: an array or an object.

If you convert it to array and then process it, or use your own function, the important thing is that your logic flows and the code does what it is intended to do.

If context is right and the code does what it is intended to do, then your code is just fine.