duangai1941 2015-11-20 11:49
浏览 19
已采纳

如何缩短多个if语句的代码?

I was thinking about this some time. I'm using a lot if statements, and sometimes I have a lot of them. I know I can use switch to shorten a bit the code. Is there another way to shorten them?

Let's say we have this example:

$all_conditions = '';

        if($post_status != ""){
            $conditions[] = "posts.post_status = '".$post_status."'";
        }
        if($post_type != ""){
            $conditions[] = "posts.post_type = '".$post_type."'";
        }
        if($meta_key != ""){
            $conditions[] = "postmeta.meta_key = '".$meta_key."'";
        }
        if($meta_value != ""){
            $conditions[] = "postmeta.meta_value = '".$meta_value."'";
        }
        if($date_begin != "" && $date_end != ""){
            $conditions[] = "( posts.post_date BETWEEN '".$date_begin."' AND '".$date_end."' )";
        }
        if(count($conditions)>0){
            $all_conditions = implode(" AND ",$conditions);
        }
        if($all_conditions != ""){
            $all_conditions = "WHERE ".$all_conditions;
        }

What should I do to not repeat all those if's?

  • 写回答

3条回答 默认 最新

  • douquqiang1513 2015-11-20 12:06
    关注

    Try this:

    <?php
    $all_conditions = '';
    $checkArr = array('post_status' =>  'posts.post_status',
                      'post_type'   =>  'posts.post_type',
                      'meta_key'    =>  'postmeta.meta_key',
                      'meta_value'  =>  'postmeta.meta_value');
    foreach ($checkArr AS $key => $val) {
        if (${$key} != '') {
            $conditions[] = "$val = '${$key}'";
        }
    }
    if($date_begin != "" && $date_end != ""){
        $conditions[] = "( posts.post_date BETWEEN '".$date_begin."' AND '".$date_end."' )";
    }
    if(count($conditions)>0){
        $all_conditions = "WHERE ".implode(" AND ",$conditions);
    }  ?>
    
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(2条)

报告相同问题?

悬赏问题

  • ¥15 基于卷积神经网络的声纹识别
  • ¥15 Python中的request,如何使用ssr节点,通过代理requests网页。本人在泰国,需要用大陆ip才能玩网页游戏,合法合规。
  • ¥100 为什么这个恒流源电路不能恒流?
  • ¥15 有偿求跨组件数据流路径图
  • ¥15 写一个方法checkPerson,入参实体类Person,出参布尔值
  • ¥15 我想咨询一下路面纹理三维点云数据处理的一些问题,上传的坐标文件里是怎么对无序点进行编号的,以及xy坐标在处理的时候是进行整体模型分片处理的吗
  • ¥15 CSAPPattacklab
  • ¥15 一直显示正在等待HID—ISP
  • ¥15 Python turtle 画图
  • ¥15 stm32开发clion时遇到的编译问题