PHP JSON用逗号和括号编码

Question

I have a php script to create a json output getting data from mysql database:

<?php
include("myconnection.php");

//Creamos y ejecutamos la consulta
$sql = "SELECT * FROM myTable where value='1003'";
$result=mysql_query($sql);

while($row = mysql_fetch_array($result)){
    $value1 = $row['value1'];
    $value2 = $row['value2'];

$data =  json_encode(
  array("value1" => $value1, 
  "value2" => $value2));

echo $data;
}

?>

I obtain a result like this:

{"value1":"847534837","value2":"Regular"}{"value1":"847534838","value2":"Regular"}

I want to obtain a result with brackets and commas like this:

[{"value1":"847534837","value2":"Regular"},{"value1":"847534838","value2":"Regular"}]

I've tried to put some echo sentences like this:

echo "[";
while($row = mysql_fetch_array($result)){
$value1 = $row['value1'];
$value2 = $row['value2'];

$data =  json_encode(
  array("value1" => $value1, 
  "value2" => $value2)).",";

echo $data;
}
echo "]";

But the result finishes with ",]" like this:

[{"value1":"847534837","value2":"Regular"},{"value1":"847534838","value2":"Regular"},]

I would like some help.

Answer 1

Let json_encode() do the work for you, don't try to roll your own encoder!!!

To get the json string output you desire, just stick items you're currently encoding one at a time in another array and encode the who enchilada one time.

  $final_array = []; notation
  while($row = mysql_fetch_array($result)){
       $final_array[] = ["value1" => $row['value1'], 
                         "value2" => $row['value2']];
  }

 echo json_encode($final_array);

NOTE: I'm assuming you're using PHP >= 5.4 and have the [] notation, otherwise replace [] and ["value1" => $row['value1'], "value2" => $row['value2']] with array() and array("value1" => $row['value1'], "value2" => $row['value2']) respectively.