I use this regexp to find and replace an HTML comment traditionally:
//remove HTML comments
$HTML = preg_replace('/<!--(.|\s)+?-->/','',$HTML);
However, on one server that's apparently crashing (works fine on my VM but it's pretty high powered).
The logic is, start the comment, any character or whitespace (at least some = +), and the ? means "don't be greedy and stop at the first --> you get"
Is there a better way to write this, esp. the (.|\s)+? part?
分享 Without a crash log, it's impossible to know exactly whether your expression is the culprit or not. Assuming it is though, it's likely the result of catastrophic backtracking due to greediness.
And not that I advocate for using regular expressions to parse HTML (you'd be better to use DOMDocument), but if you continue down the regex path use:
$HTML = preg_replace('/<!--([\s\S]+?)-->/','',$HTML);
instead. It'll capture both whitespace and non whitespace, including new lines, and won't blow up due to backtracking.
Example: https://regex101.com/r/qR1xW1/1
分享
