foreach循环运行一次

Question

So I'm having an issue with my foreach loop only running once.

I have the following data for the $file_url variable.

$file_url = "http://www.somedomain.com/12355/1.jpg,http://www.somedomain.com/12355/2.jpg,http://www.somedomain.com/12355/3.jpg,http://www.somedomain.com/12355/4.jpg";

Now my code looks like this:

function fetch_media($file_url,$vin,$cacheid) {
    require_once(ABSPATH . 'wp-load.php');
    require_once(ABSPATH . 'wp-admin/includes/image.php');
    global $wpdb;

    if(!$vin) {
        $vin = $cacheid;
    }

    $vin = $vin . '/';

    //directory to import to    
    $artDir = "wp-content/uploads/vehiclephotos/$vin";

    //if the directory doesn't exist, create it 
    if(!file_exists(ABSPATH.$artDir)) {
        mkdir(ABSPATH.$artDir);
    }

    $file_url = explode(",", $file_url);
    $gallery_images = array();

    foreach ($file_url as $url) {

    //rename the file... alternatively, you could explode on "/" and keep the original file name
    $filename = array_pop(explode("/", $url));

        if (@fclose(@fopen($url, "r"))) { //make sure the file actually exists
            copy($url, ABSPATH.$artDir.$filename);

            $siteurl = get_option('siteurl');
            $file_info = getimagesize(ABSPATH.$artDir.$filename);

            //create an array of attachment data to insert into wp_posts table
            $artdata = array();
            $artdata = array(
                'post_author' => 1, 
                'post_date' => current_time('mysql'),
                'post_date_gmt' => current_time('mysql'),
                'post_title' => $filename, 
                'post_status' => 'inherit',
                'comment_status' => 'closed',
                'ping_status' => 'closed',
                'post_name' => sanitize_title_with_dashes(str_replace("_", "-", $filename)),
                'post_modified' => current_time('mysql'),
                'post_modified_gmt' => current_time('mysql'),
                'post_type' => 'attachment',
                'guid' => $siteurl.'/'.$artDir.$filename,
                'post_mime_type' => $file_info['mime'],
                'post_excerpt' => '',
                'post_content' => ''
            );

            $uploads = wp_upload_dir();
            $save_path = $uploads['basedir'].'/vehiclephotos/'.$vin.$filename;

            //insert the database record
            $attach_id = wp_insert_attachment($artdata, $save_path);

            //generate metadata and thumbnails
            if ($attach_data = wp_generate_attachment_metadata( $attach_id, $save_path)) {
                wp_update_attachment_metadata($attach_id, $attach_data);
            }

            array_push($gallery_images,$attach_id);
            }

    }

    return serialize($gallery_images);
}

So the output I'm getting is the serialized array which is:

a:1:{i:0;i:103525;}

Which is fine, but since there were 4 array items, it should have looped 4 times and given me the serialized data with 4 attachment_id's. All the other code in there runs fine once, it downloads the image from the URL, it renames it and creates all thumbnail sizes of the photo fine.

Any idea what I'm doing wrong?

Answer 1

While troubleshooting, remove the @-operator to see what errors you get. So:

if (@fclose(@fopen($url, "r"))) { //make sure the file actually exists

becomes:

if (fclose(fopen($url, "r"))) { //make sure the file actually exists

You could probably simplify this line to:

if (file_exists($url)) {