too long

Question

I do not understand what is best practice to get data from a database in a MVC framework. I have seen two scenario's:

1. Do the database query in the Controller class

$feeds = Feedback::find()->orderBy('RAND()')->limit(4)->all();

1. Do the database query in the Model class, and call this method from a Controller class

$categories = Category::getCategoriesList();

What is the correct way? Which tasks should I perform in a Controller class and which should I perform in a Model class?

Answer 1

There is much debate where to put your business logic in MVC.

Generally speaking, in MVC architectures one separates at least database logic (Model) from your Controller.

Database specific queries are done in the model.

Methods in your Controller handle requests (resolve routes) and create the proper response (a view or plain data).

Example

If you have a route/url /feedback you would have a 'feedback()' method in your FeedbackController.

class FeedbackController {

  use Feedback; 

  public function feedback(){
     return Feedback::list();
  }
}

In your Model (Feedback) you now need a method list().

class Feedback extends Model {

  public static function list(){
     return ( your_database_specific_query_which_returns_a_list_of_records );
  }

}