有些人可以帮我清除/合并代码

Im busy with a Call of Duty Black Ops 4 with my friends.

Now I have it work but i want to combine the code, because I repeat for every username the whole cURL information. Can someone help me with cleaning my code :)

I have put between the code wich keeps repeating.

Now I have 6 usernames and it means that I repeat every time my cUrl request and a row.

Im sure that it can work more easier than I did.

<?php
if(isset($_GET['user']) && $_GET['user'] != '') {
    $url = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/'.$_GET['user'];
}else{
    $url = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/gurdt';
}

<!--- REPEAT FOR EVERY USERNAME !--->
$userGurdt = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/gurdt';
<!--- END REPEAT FOR EVERY USERNAME !--->
$userRay = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/the_green_ray';
$userRamon = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/hilhorst95';
$userMark = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/r6dutchmennl';
$userLeon = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/theaxeman777';
$userDan = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/fscdan';

<!--- REPEAT FOR EVERY USERNAME !--->
// Gurdt
$chGurdt = curl_init($userGurdt);
curl_setopt($chGurdt, CURLOPT_USERPWD, 'TRN-Api-Key: XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX');
curl_setopt($chGurdt, CURLOPT_RETURNTRANSFER, true);
$responseGurdt = curl_exec($chGurdt);

if(curl_errno($chGurdt)){
    //If an error occured, throw an Exception.
    throw new Exception(curl_error($chGurdt));
}

$outputGurdt = json_decode($responseGurdt);

$usernameGurdt = $outputGurdt->data->metadata->platformUserHandle;
$levelGurdt = $outputGurdt->data->stats[0]->value;
$levelImgGurdt = $outputGurdt->data->stats[0]->metadata->iconUrl;
$killsGurdt = $outputGurdt->data->stats[2]->value;
$deathsGurdt = $outputGurdt->data->stats[3]->value;
$kdGurdt = $outputGurdt->data->stats[1]->value;
<!--- END REPEAT FOR EVERY USERNAME !--->
/////////////////////////////////////////////////////////////////////////////////////////////////////////////
// The_Green_Ray
$chRay = curl_init($userRay);
curl_setopt($chRay, CURLOPT_USERPWD, 'TRN-Api-Key: XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX');
curl_setopt($chRay, CURLOPT_RETURNTRANSFER, true);
$responseRay = curl_exec($chRay);

if(curl_errno($chRay)){
    //If an error occured, throw an Exception.
    throw new Exception(curl_error($chRay));
}

$outputRay = json_decode($responseRay);

$usernameRay = $outputRay->data->metadata->platformUserHandle;
$levelRay = $outputRay->data->stats[0]->value;
$levelImgRay = $outputRay->data->stats[0]->metadata->iconUrl;
$killsRay = $outputRay->data->stats[2]->value;
$deathsRay = $outputRay->data->stats[3]->value;
$kdRay = $outputRay->data->stats[1]->value;
/////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Ramon
$chRamon = curl_init($userRamon);
curl_setopt($chRamon, CURLOPT_USERPWD, 'TRN-Api-Key: XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX');
curl_setopt($chRamon, CURLOPT_RETURNTRANSFER, true);
$responseRamon = curl_exec($chRamon);

if(curl_errno($chRamon)){
    //If an error occured, throw an Exception.
    throw new Exception(curl_error($chRamon));
}

$outputRamon = json_decode($responseRamon);

$usernameRamon = $outputRamon->data->metadata->platformUserHandle;
$levelRamon = $outputRamon->data->stats[0]->value;
$levelImgRamon = $outputRamon->data->stats[0]->metadata->iconUrl;
$killsRamon = $outputRamon->data->stats[2]->value;
$deathsRamon = $outputRamon->data->stats[3]->value;
$kdRamon = $outputRamon->data->stats[1]->value;
/////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Mark
$chMark = curl_init($userMark);
curl_setopt($chMark, CURLOPT_USERPWD, 'TRN-Api-Key: XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX');
curl_setopt($chMark, CURLOPT_RETURNTRANSFER, true);
$responseMark = curl_exec($chMark);

if(curl_errno($chMark)){
    //If an error occured, throw an Exception.
    throw new Exception(curl_error($chMark));
}

$outputMark = json_decode($responseMark);

$usernameMark = $outputMark->data->metadata->platformUserHandle;
$levelMark = $outputMark->data->stats[0]->value;
$levelImgMark = $outputMark->data->stats[0]->metadata->iconUrl;
$killsMark = $outputMark->data->stats[3]->value;
$deathsMark = $outputMark->data->stats[4]->value;
$kdMark = $outputMark->data->stats[2]->value;
/////////////////////////////////////////////////////////////////////////////////////////////////////////////
// Leon
$chLeon = curl_init($userLeon);
curl_setopt($chLeon, CURLOPT_USERPWD, 'TRN-Api-Key: XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX');
curl_setopt($chLeon, CURLOPT_RETURNTRANSFER, true);
$responseLeon = curl_exec($chLeon);

if(curl_errno($chLeon)){
    //If an error occured, throw an Exception.
    throw new Exception(curl_error($chLeon));
}

$outputLeon = json_decode($responseLeon);

$usernameLeon = $outputLeon->data->metadata->platformUserHandle;
$levelLeon = $outputLeon->data->stats[0]->value;
$levelImgLeon = $outputLeon->data->stats[0]->metadata->iconUrl;
$killsLeon = $outputLeon->data->stats[3]->value;
$deathsLeon = $outputLeon->data->stats[4]->value;
$kdLeon = $outputLeon->data->stats[2]->value;
///////////////////////////////////////////////////////////////////////////////

//////////////////////////////
// Danny
$chDan = curl_init($userDan);
curl_setopt($chDan, CURLOPT_USERPWD, 'TRN-Api-Key: XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX');
curl_setopt($chDan, CURLOPT_RETURNTRANSFER, true);
$responseDan = curl_exec($chDan);

if(curl_errno($chDan)){
    //If an error occured, throw an Exception.
    throw new Exception(curl_error($chDan));
}

$outputDan = json_decode($responseDan);

$usernameDan = $outputDan->data->metadata->platformUserHandle;
$levelDan = $outputDan->data->stats[0]->value;
$levelImgDan = $outputDan->data->stats[0]->metadata->iconUrl;
$killsDan = $outputDan->data->stats[2]->value;
$deathsDan = $outputDan->data->stats[3]->value;
$kdDan = $outputDan->data->stats[1]->value;
///////////////////////////////////////////////////////////////////////////////
?>
<!doctype html>
<html lang="nl">
<head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.0/css/bootstrap.min.css" integrity="sha384-PDle/QlgIONtM1aqA2Qemk5gPOE7wFq8+Em+G/hmo5Iq0CCmYZLv3fVRDJ4MMwEA" crossorigin="anonymous">
    <title>N033 Stats</title>
</head>
<body>
<div class="container">
    <div class="col-sm-6 offset-sm-4">
        <table class="table">
            <thead>
            <tr>
                <th>Username</th>
                <th>Level</th>
                <th>Kills</th>
                <th>Deaths</th>
                <th>K/D</th>
            </tr>
            </thead>
            <tbody>
<!--- REPEAT FOR EVERY USERNAME !--->
            <tr>
                <td valign="middle"><?php echo $usernameGurdt;?></td>
                <td valign="middle"><?php echo '<img src="'.$levelImgGurdt.'" width="40" height="40"/> '.$levelGurdt;?></td>
                <td valign="middle"><?php echo $killsGurdt;?></td>
                <td valign="middle"><?php echo $deathsGurdt;?></td>
                <td valign="middle"><?php echo $kdGurdt;?></td>
            </tr>
<!--- END REPEAT FOR EVERY USERNAME !--->
            <tr>
                <td valign="middle"><?php echo $usernameRay;?></td>
                <td valign="middle"><?php echo '<img src="'.$levelImgRay.'" width="40" height="40"/> '.$levelRay;?></td>
                <td valign="middle"><?php echo $killsRay;?></td>
                <td valign="middle"><?php echo $deathsRay;?></td>
                <td valign="middle"><?php echo $kdRay;?></td>
            </tr>
            <tr>
                <td valign="middle"><?php echo $usernameRamon;?></td>
                <td valign="middle"><?php echo '<img src="'.$levelImgRamon.'" width="40" height="40"/> '.$levelRamon;?></td>
                <td valign="middle"><?php echo $killsRamon;?></td>
                <td valign="middle"><?php echo $deathsRamon;?></td>
                <td valign="middle"><?php echo $kdRamon;?></td>
            </tr>
            <tr>
                <td valign="middle"><?php echo $usernameMark;?></td>
                <td valign="middle"><?php echo '<img src="'.$levelImgMark.'" width="40" height="40"/> '.$levelMark;?></td>
                <td valign="middle"><?php echo $killsMark;?></td>
                <td valign="middle"><?php echo $deathsMark;?></td>
                <td valign="middle"><?php echo $kdMark;?></td>
            </tr>
            <tr>
                <td valign="middle"><?php echo $usernameLeon;?></td>
                <td valign="middle"><?php echo '<img src="'.$levelImgLeon.'" width="40" height="40"/> '.$levelLeon;?></td>
                <td valign="middle"><?php echo $killsLeon;?></td>
                <td valign="middle"><?php echo $deathsLeon;?></td>
                <td valign="middle"><?php echo $kdLeon;?></td>
            </tr>
            <tr>
                <td valign="middle"><?php echo $usernameDan;?></td>
                <td valign="middle"><?php echo '<img src="'.$levelImgDan.'" width="40" height="40"/> '.$levelDan;?></td>
                <td valign="middle"><?php echo $killsDan;?></td>
                <td valign="middle"><?php echo $deathsDan;?></td>
                <td valign="middle"><?php echo $kdDan;?></td>
            </tr>
            </tbody>
        </table>
    </div>
</div>

<script src="https://code.jquery.com/jquery-3.3.1.slim.min.js" integrity="sha384-q8i/X+965DzO0rT7abK41JStQIAqVgRVzpbzo5smXKp4YfRvH+8abtTE1Pi6jizo" crossorigin="anonymous"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.7/umd/popper.min.js" integrity="sha384-UO2eT0CpHqdSJQ6hJty5KVphtPhzWj9WO1clHTMGa3JDZwrnQq4sF86dIHNDz0W1" crossorigin="anonymous"></script>
<script src="https://stackpath.bootstrapcdn.com/bootstrap/4.3.0/js/bootstrap.min.js" integrity="sha384-7aThvCh9TypR7fIc2HV4O/nFMVCBwyIUKL8XCtKE+8xgCgl/PQGuFsvShjr74PBp" crossorigin="anonymous"></script>
</body>
</html>

写回答
好问题 0 提建议
追加酬金
关注问题
分享
邀请回答
编辑收藏删除结题
收藏举报

1条回答默认最新

dtbsezxw28056 2019-02-13 13:05

关注

I rewrote your code a little bit by doing what I described in the comment to your question:

<?php
error_reporting(-1);
ini_set('display_errors', 'On');

$baseUrl = 'https://cod-api.tracker.gg/v1/standard/bo4/profile/2/';
$apiKey = 'XXXXXXX-XXXX-XXXXX-XXXX-XXXXXXXXXXXX';

$users = [
    'gurdt' => [
        'id' => 'gurdt'
    ],
    'ray' => [
        'id' => 'the_green_ray'
    ],
    'ramon' => [
        'id' => 'hilhorst95'
    ],
    'mark' => [
        'id' => 'r6dutchmennl'
    ],
    'leon' => [
        'id' => 'theaxeman777'
    ],
    'dan' => [
        'id' => 'fscdan'
    ]
];

$result = [];

foreach ($users as $user) {
    $url = $baseUrl . $user['id'];
    $ch = curl_init($url);
    curl_setopt($ch, CURLOPT_USERPWD, 'TRN-Api-Key: ' . $apiKey);
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
    $response = curl_exec($ch);

    if (curl_errno($ch)) {
        //If an error occured, throw an Exception.
        throw new Exception(curl_error($ch));
    }
    $output = json_decode($response, true);
    $result[$user['id']]['username'] = $output['data']['metadata']['platformUserHandle'];
    $result[$user['id']]['level'] = $output['data']['stats'][0]['value'];
    $result[$user['id']]['levelImg'] = $output['data']['stats'][0]['metadata']['iconUrl'];
    $result[$user['id']]['kd'] = $output['data']['stats'][1]['value'];
    $result[$user['id']]['kills'] = $output['data']['stats'][2]['value'];
    $result[$user['id']]['deaths'] = $output['data']['stats'][3]['value'];
}

var_dump($result);

?>

EDIT: I have cleaned up the presentation layer a bit too, you don't have to use <?php echo ?> all over the place in your HTML, its kinda unreadable. Instead you can use something like heredoc to make it more readable:

<div class="container">
    <div class="col-sm-6 offset-sm-4">
        <table class="table">
            <thead>
            <tr>
                <th>Username</th>
                <th>Level</th>
                <th>Kills</th>
                <th>Deaths</th>
                <th>K/D</th>
            </tr>
            </thead>
            <tbody>
            <?php foreach ($result as $r) {
                $username = $r['username'];
                $levelImg = $r['levelImg'];
                $level = $r['level'];
                $kills = $r['kills'];
                $deaths = $r['deaths'];
                $kd = $r['kd'];
                echo <<<EOT
            <tr>
            <td valign="middle">$username</td>
            <td valign="middle"><img src="$levelImg" width="40" height="40"/>$level</td>
            <td valign="middle">$kills</td>
            <td valign="middle">$deaths</td>
            <td valign="middle">$kd</td>
            </tr>
EOT;
            } ?>

            </tbody>
        </table>
    </div>
</div>

本回答被题主选为最佳回答 , 对您是否有帮助呢?

报告相同问题？

关注问题

有些人可以帮我清除/合并代码 html php
2019-02-13 12:50

回答 1 已采纳 I rewrote your code a little bit by doing what I described in the comment to your question: <?
前端怎么自动在input输入框选中几个字符，方便用户点一次backspace就可以清除输入框的东西 javascript 前端
2022-03-02 22:44

回答 1 已采纳按如下代码可以实现，根据业务需要，比如双击触发、聚焦触发、单击触发，把 onfocus 事件改成别的就好啦 <!DOCTYPE html> <html lang="en">
js无缝滚动,谁帮我解读下下面这段代码 javascript
2017-11-04 08:00

回答 1 已采纳滚动得距离大于obj宽度时，obj滚动的距离回到原点，否则obj继续滚动
前端代码规范
2024-02-04 15:37

小木木爸的博客使用，连接符例如：使用命名例如：文件命名：组件命名：使用，下划线拼接，例如：使用命名动词+名词形式尽量使用箭头函数例如：构造函数使用函数方法常用的动词: ...建议代码尽量控制在 500 以内
前端在点击退出功能的时候报403然后清除浏览器cookies后在点击退出可以正常退出 java node.js vue.js
2022-06-02 12:21

回答 1 已采纳 403会不会是你请求头没带cookies
哪位大神可以帮我翻译一下这个带液晶显示的充电器代码，多谢。
2016-06-11 01:17

回答 1 已采纳不用翻译，猜测就行了。 ADC采集充电宝电压，然后在LCD上显示。出现过电压，过电流，终端控制继电器关闭充电通道。很简单51单片机知识
我这代码如何改成链表，希望能提供思路帮助 c++
2023-03-07 09:16

回答 4 已采纳 “Devil组”引证GPT后的撰写：需要以下几个步骤：定义链表节点结构体 Node，包括 struct student 中的所有成员变量以及一个指向下一个节点的指针 next。在 main() 函
2023前端面试题第二弹（真实，一般人我还不给看）
2023-02-12 00:15

蒙奇不想敲代码的博客前几个月我和我的小伙伴遇到的面试题，希望能帮助到各位，我已经上岸了哦，面5过4，第一家没过因为没背面试题，加油各位
前端播放flv处理延迟手动跳帧后一直转圈圈 vue.js 前端
2022-11-07 09:34

回答 1 已采纳 // 视频流延迟 setInterval(() => { if (this.flvPlayer.buffered.length) { l
labwindows/cvi中DeleteGraphPlot函数可以只清除一条特定的线吗 c语言
2020-11-06 16:48

回答 1 已采纳请问下怎么在一个graph中画好几条曲线呢
如何消除代码中的警告？ c语言有问必答
2022-03-19 21:15

回答 3 已采纳不要在结构定义的时候初始化。这个功能支持需要C++11，或者GNU++11，你看看你的编译器是否支持吧一般这么写typedef struct{int number;char name[10];char
前端代码书写tips
2022-10-30 11:35

AriesTina的博客前端项目代码书写规范，写出好代码，每一行代码都应当有它存在的意义。如果没有意义，请立即修正
用c语言输出杨辉三角形的前10行数，为什么我的代码运行结果出现了负数，怎么样可以把负数消除掉，是我的代码出问题了？ c语言
2022-11-05 18:10

回答 1 已采纳 #include <stdio.h> int main() { int a[10][10], i, j; for (i=0; i<10; i++) {
前端代码规范文档
2022-12-27 07:59

jayues_lies的博客 ●[建议] img 标签缺少alt属性时，sonar警告消除使用/ eslint-disable jsx-a11y/alt-text /。要么这条语句是多余的，应该删除，要么重新赋值是错误的，应该使用其他值或变量来代替赋值。●[建议] 有下载需求的图片...
前端代码规范（个人约束）
2022-10-20 17:50

Dr苏的博客基于 B站的学习视频：前端必备-阿里大厂前端开发规范！整理的个人前端规则
没有解决我的问题, 去提问

悬赏问题

¥15 写一个方法checkPerson，入参实体类Person，出参布尔值
¥15 我想咨询一下路面纹理三维点云数据处理的一些问题，上传的坐标文件里是怎么对无序点进行编号的，以及xy坐标在处理的时候是进行整体模型分片处理的吗
¥15 CSAPPattacklab
¥15 一直显示正在等待HID—ISP
¥15 Python turtle 画图
¥15 关于大棚监测的pcb板设计
¥15 stm32开发clion时遇到的编译问题
¥15 lna设计源简并电感型共源放大器
¥15 如何用Labview在myRIO上做LCD显示？(语言-开发语言)
¥15 Vue3地图和异步函数使用

码龄粉丝数原力等级 --

有些人可以帮我清除/合并代码

1条回答默认最新

码龄粉丝数原力等级 --

悬赏问题

有些人可以帮我清除/合并代码

1条回答 默认 最新

悬赏问题

1条回答默认最新