如何最好地使用OOP原则来处理具有10-15 +匹配标准的情况，这些标准都需要通过？

Question

I have a class that takes in lines of text and uses about 15 different "criteria" (individual preg_match statements) to check if the line should qualify to be saved in an array.

How does one best handle such a situation with clean, maintainable code?

Initially I had a crazy long if statement which had all the criteria, for example:

if (
    preg_match($criteria1,$line) &&
    preg_match($criteria2, $line) &&
    ...
    ...
    ...
    preg_match($criteriaN,$line)
) {
    //do something, e.g. save the line to an array.
}

I've since put each preg_match statement into a different function within a separate class and call each function in a row, checking if it's true... But now I have 15 separate functions that are only subtly different from each other and it still doesn't feel like I'm writing good code. How is it best to handle this situation?

Answer 1

Well, if you want to keep things object oriented, you could use a class like this...

class Validator{

    /* Any criteria needing to be met must exist in this array */
    public static $criterias = array($criteria1,
                                      $criteria2,
                                      ... ,
                                      $criteriaN);



    public static function validate($line){

        /* Make sure this line meets each criteria */
        foreach(Validator::$criterias as $criteria){

              if(!preg_match($criteria, $line))
                   return false;
        }

        return true;
    }

It makes sense to have the methods and properties static because they are unique to no instance. Then you can simply check to see if a line meets the criteria by calling

Validator::validate($line)