dongyi2425 2016-09-22 12:58
浏览 10
已采纳

如何测试传递给方法构造的对象的参数顺序

I'm testing a simple factory class with a single method which returns a TagModel.

class TagFactory
{
    public function buildFromArray(array $tagData)
    {
        return new TagModel(
            $tagData['t_id'],
            $tagData['t_promotion_id'],
            $tagData['t_type_id'],
            $tagData['t_value']
        );
    }
}

I can test the method…

public function testbuildFromArray()
{
    $tagData = [
        't_id' => 1,
        't_promotion_id' => 2,
        't_type_id' => 3,
        't_value' => 'You are valued',
    ];    

    $tagFactory = new TagFactory();
    $result = $tagFactory->buildFromArray($tagData);
    $this->assertInstanceOf(TagModel::class, $result);
}

If I change the order of the parameters in new TagModel… the test will still pass.

If I prophesize the TagModel

$tagModel = $this->prophesize(TagModel::class);
    $tagModel->willBeConstructedWith(
        [
            $tagData['t_id'],
            $tagData['t_promotion_id'],
            $tagData['t_type_id'],
            $tagData['t_value']
        ]
    );

… but what should I then be asserting? assertSame doesn't work because they aren't.

I could test the order with the getters from the TagModel but then I've gone beyond testing just this unit. Yet I do feel that the order should be tested because if I change them the test still passes.

  • 写回答

1条回答 默认 最新

  • douyin4875 2016-09-23 21:34
    关注

    The method you're testing is a factory. It creates an object. If making sure it's of the expected type is not enough for you, you need to verify its state. Either inspect it with getters, or create an object you're expecting to receive and use assertEquals() to compare it.

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥15 我的b站在没有碰到屏幕的情况下偶尔会自动跳出进度条,就像在屏幕上点了一下一样,但我并没有点。而且视频进度并没有变。这可能是什么原因造成的?
  • ¥30 STK matlab python仿真
  • ¥15 关于IMageEnView 图标定位问题
  • ¥20 求解答(matlab)
  • ¥30 ffmpeg库使用过程中遇到的问题
  • ¥15 pyqt5 中python如何通过Qtwebchannel主动发消息给web前端
  • ¥15 关于HTML中title获取xml内容的问题
  • ¥15 fanuc机器人PRIO083数字信号未复原错误,如何解决?
  • ¥20 如何为现有电路板增加远程控制功能
  • ¥15 UE5打包失败,求解决