在另一个方法中调用方法是一个好习惯吗？ - PHP

Question

I would like to know if it's recommended to do this:

class User {

    public function __construct() {
        parent::__construct();
    }
    public function exists($token) {
        //return true if token exists otherwise return false
    }
    public function createSession($token) {
        if($this->exists($token))
            //create session
        else
            //redirect
    }
}

I think it could be not recommended in case of a change in the exists method of the class but I think that'll not happen, What do you recommend me to do?

Answer 1

There's nothing wrong with calling methods from other methods. In many designs, it's critical that you do this. This allows you to create subclasses that redefine the method, and the new definition will be called.

So if you do:

class SpecialUser extends User {
    public function exists($token) {
        // determine token existence in some other way
    }
}

You can then do:

$s = new SpecialUser;
$s->createSession($someToken);

and it will make use of the special way that SpecialUser checks tokens.