在Laravel 5中调用模型中的方法

Question

I've created a model called Hangman. Inside a controller I'm inserting a row in the database like this

$hangman = new Hangman();
$hangman->word = 'exampleWord';
$hangman->lives = 3;
$hangman->save();

So far so good.

I've got two questions:

1) Is it best practice to keep inserting things in the controller?

I assume NO, so I created this method in the model, which I think would be cleaner to call from the controller

public function insert($word, $lives)
{
    $hangman = new Hangman();
    $hangman->word = $word;
    $hangman->lives = $lives;
    $hangman->save();

    return $hangman;
}

So, my real question (assuming question 1 is NO) is:

2) How would I call this method from the controller?

This doesn't work

 \App\Hangman::insert('exampleword', 4);

Namespaces are correct.

I know it's very basic, thanks guys

Answer 1

Nobody can answer your first question properly, as it's a matter of personal preference and people have various opinions. Putting it in the model may be a good idea, as might putting it in a repository. In the right application, having it in a controller might be worth it, whereas other systems may favour yet other solutions.

As for your second question: since you're in the Hangman model, you should make the self-referential call static, and also the method itself.

public static function insert($word, $lives)
{
    $hangman = new static;
    $hangman->word = $word;
    $hangman->lives = $lives;
    $hangman->save();

    return $hangman;
}

And that should be enough. You could also save yourself a few lines:

public static function insert($word, $lives)
{
    return static::create(compact('word', 'lives'));
}