My website runs on WordPress, and includes an account activation system that works like this:
- User creates account, gets logged in immediately and is shown the home page.
- A function checks the database to see if the account is activated, and if not, displays a message on the home page asking to click the link in the verification email.
- User opens their email and clicks the activation link. (example: https://example.com/?action=activate&user=swen&key=1234)
- On opening this page, a function checks if an
action
argument is set and runs the account activation function, which then updates the account to 'activated'. - The rest of WP is executed, but the function checking for account activation still shows that the account has not been activated.
- Upon browsing to https://example.com again without query vars, the message disappears, showing that the above example URL, did in fact work to activate the account.
Is it possible that the time between writing data to the database, and retrieving that same updated data is too short?
UPDATE:
Wondering if MySQL caches the data in the same pageload. I tried flushing the WordPress cache before retrieving the updated user role, no luck.
Action that checks URL and runs the activate_user
function:
I tried doing this as early as possible with the setup_theme
hook to ensure it's run before the theme is loaded.
add_action('setup_theme', 'ns_activate_user_action');
function ns_activate_user_action() {
// Check if all action parameters are present
if ( !ns_validate_action('activate', array('user', 'key')) ) {
return;
}
// Activate user by key, runs the "activate_user" function
$activate_user = activate_user_by_key($_GET['user'], $_GET['key']);
// At this point the user role should have changed
// and the account be activated
}
Function that activates account:
function activate_user($user) {
// ...
$user->add_role( 'member' );
$user->remove_role( 'member_pending' );
// ...
return $user;
}
Function that checks if account is activated:
function is_user_activated($user) {
// ...
if ( in_array( 'member_pending', (array) $user->roles ) ) {
return false;
}
return true;
}
Custom action displays activation message, is called with do_action()
in theme file:
add_action('ns_after_header', 'ns_activate_account_notice_front_page');
function ns_activate_account_notice_front_page() {
if ( is_user_logged_in() && is_front_page() && !is_user_activated() ) {
// ... Echos message asking user to click activation link in email
// Checking the user role here with wp_get_current_user()->roles
// still shows that the user is in the "member_pending" role (inactive)
}
}