有没有办法将这3个查询合二为一

Question

I have this code which is really not the prettiest and the most efficient. The code works but i feel like there is way to avoid all the looping and combine these queries and make possibly one array. I was just wondering if anyone had any pointers on how to improve this

$sql = "SELECT p.image, group_concat(pi.image) as additional_images 
FROM product as p 
JOIN product_image as pi on pi.product_id=p.product_id 
WHERE p.product_id = '{$product['standard']['product_id']}'";
$result = mysql_query($sql);
$images_before = mysql_fetch_assoc($result);
$images = array();
if($images_before['additional_images'] != ""){
$images = explode(",", $images_before['additional_images']);
}
array_push($images, $images_before['image']);
$sql2 = "SELECT p.image, group_concat(pi.image) as additional_images 
FROM product as p 
JOIN product_image as pi on pi.product_id=p.product_id 
WHERE p.product_id = '{$product['professional']['product_id']}'";
$result2 = mysql_query($sql2);
$images_before2 = mysql_fetch_assoc($result2);
$images2 = array();
if($images_before2['additional_images'] != ""){
$images2 = explode(",", $images_before2['additional_images']);
}
array_push($images2, $images_before2['image']);
$sql3 = "SELECT p.image, group_concat(pi.image) as additional_images 
FROM product as p 
JOIN product_image as pi on pi.product_id=p.product_id 
WHERE p.product_id = '{$product['premium']['product_id']}'";
$result3 = mysql_query($sql3);
$images_before3 = mysql_fetch_assoc($result3);
$images3 = array();
if($images_before3['additional_images'] != ""){
$images3 = explode(",", $images_before3['additional_images']);
}
array_push($images3, $images_before3['image']);
$counter = 0;
foreach($images as $image) {
      if ($counter == 0) {
          echo "<a id='show_{$product['standard']['product_id']}' style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['standard']['product_id']}]'></a>";
                $counter++;
      }else{
        echo "<a style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['standard']['product_id']}]'></a>";
            $counter++;
        }
}

$counter2 = 0;
  foreach($images2 as $image) {
        if ($counter2 == 0) {
            echo "<a id='show_{$product['professional']['product_id']}' style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['professional']['product_id']}]'></a>";
                    $counter2++;
        }else{
          echo "<a style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['professional']['product_id']}]'></a>";
                $counter2++;
            }
}
$counter3 = 0;
    foreach($images3 as $image) {
          if ($counter3 == 0) {
              echo "<a id='show_{$product['premium']['product_id']}' style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['premium']['product_id']}]'></a>";
                        $counter3++;
          }else{
            echo "<a style='display:none;' href='http://somesite.com/shop_possystems/image/{$image}' rel='prettyPhoto[show_{$product['premium']['product_id']}]'></a>";
                    $counter3++;
                }
    }
?>

Answer 1

Instead of using where p.product_id = <value>, use WHERE IN syntax:

$sql = "SELECT  ...
WHERE p.product_id IN (
  {$product['standard']['product_id']},
  {$product['professional']['product_id']}, 
  {$product['premium']['product_id']}
)";