如何以更清洁的方式格式化数组数据？

Question

I have this method:

private function formatCliendCardData($data) {
    $formatedData = array();

    $formatedData['first_name'] = trim($data['name']);
    $formatedData['last_name'] = trim($data['surname']);
    $formatedData['date_of_birth'] = $data['birth_year'] . '-' . sprintf("%02d", $data['birth_month_id']) . '-' . sprintf("%02d", $data['birth_day']); //[yyyy-mm-dd]
    $formatedData['sex'] = ($data['sex_id'] == 's1'? 'm' : 'f');
    $formatedData['county'] = 'Latvija'; //@TODO get real data
    $formatedData['post_index'] = (int) preg_replace( '/[^0-9]/', '', $data['post_index']);
    $formatedData['city'] = trim($data['city']);
    $formatedData['street'] = trim($data['street']);
    $formatedData['house_nr'] = trim($data['house_nr']);
    $formatedData['phone'] = trim($data['phone']);
    $formatedData['email'] = trim($data['email']);

    return $formatedData;
}

I run in this problem from time to time. I have big method that just reformats data and returns it. It looks ugly. There is few other aproaches Im aware -- just make foreach loop, but there are exeptions, so i need make 'ifs' anyway. What is better way to reformat such data in your opinon?

Answer 1

I aggree with helloei,

create a class to handle all the formating and validation in the setter.

class Person
{
 public function setName($name)
 {
   $this->name = trim($name);
 }
 ...
}

and then create the object in your function:

private function formatCliendCardData($data) {
    $person = new Person();
    $person->setName($data['name`])
    ...