Laravel集合映射函数会覆盖默认集合

Question

I have a code where I use map to create a new collection of high scores. The problem I have is that it overrides the default user collections. Which is not my intention.

Here is the code

    $users = Users::all();
    $highscore = $users->map(
        function ($user) {
            $calls = $user->calls->filter(
                function ($call) {
                    $date = Carbon::parse($call->datetime)->format("Y-m-d");
                    $today = Carbon::now()->format("Y-m-d");
                    return $date == $today;
                }
            );
            return [
                'id' => $user->id,
                'duration' => $calls->sum('duration'),
            ];
        }
    );

If i dump the first user after getting all the users I get the first user. Like this.

$users = Users::all();
dd($users->first());

If I dump the first user after the high score map. I get all Calls from that user which is another model. Which means that the users collection has been modified. Like this.

$highscore = $users->map(
    function ($user) {
        $calls = $user->calls->filter(
            function ($call) {
                $date = Carbon::parse($call->datetime)->format("Y-m-d");
                $today = Carbon::now()->format("Y-m-d");
                return $date == $today;
            }
        );
        return [
            'id' => $user->id,
            'duration' => $calls->sum('duration'),
        ];
    }
);
dd($users->first()):

Any idea on how to handle this behaviour?

Answer 1

The map function returns an array of [[$userId => $duration], ...]. What you want to do is to order your users by the sum of their calls.

I believe that, in order to do that easily, you should add to your User model:

public function getTodayCallSum() {
    return $user->calls->filter(function($call) {
        $date = Carbon::parse($call->datetime)->format("Y-m-d");
        $today = Carbon::now()->format("Y-m-d");
        return $date == $today;
    })->sum('duration');
}

And then edit your query:

$users = User::all();
$firstUser = $users->sortBy('todayCallSum')->first();

I haven't tested this code, but I think it should help you towards the right direction.