doutang1856 2014-04-29 08:51
浏览 35
已采纳

Laravel - Eloquent Code位置 - 控制器或模型

I'm trying to decide on something, where to put database logic, in the controller or model when using the eloquent orm.

In a controller I have the following method:

public function postAdd(){
$amodel=new myModel();
$amodel->name=Input::get('name');
$amodel->save();
$id=$amodel->id;
}

Which is how the guides say to use it however should this logic not go inside a method on the model rather than in the controller? I know the above still provides abstraction from the database but the bit that I'm unsure of is how reusable it then becomes... or not as the case maybe.

Would it therefore be a better option to do the following:

public function postAdd(){
$amodel=new myModel();
$id = $amodel->addPost(Input::get('name'));
}

So I pass along information to a method on the model which does the work. This allows it to be reused and the model method changed if required without updating many lines of code?

The answer might simply be 'yes, do it like you've suggested' in which case great but I'd be interested on the standard practice when using an ORM like this.

  • 写回答

1条回答 默认 最新

  • doujia2090 2014-04-29 08:59
    关注

    A controller's sole responsibility is handling and delegating UI requests to the Model. That's why it should be skinny. It should only contain code necessary for what it's responsible for. So thats why you should move your code to the model, or, even better and more Laravel-like solution is to use repositories in this case. (link)

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?