dongxian3574 2015-02-11 12:30
浏览 9
已采纳

处理错误非常无聊

I have struct that have a method that serve the response.

type ctrl struct {
    *base.AjaxCtrl
    file ini.File
}

func (rcv *ctrl) getVar() string {
    return mux.Vars(rcv.Req)["location"]
}

func (rcv *ctrl) getFile() string {
    return location.JoinPaths(folder, rcv.getVar()+ext)
}

func (rcv *ctrl) upload() {
    file, err := ini.LoadFile(rcv.getFile())
    if err != nil {
        rcv.AddErr("TextError", err.Error())
        return
    }
    rcv.file = file
}

// Convert text to json structure
func (rcv *ctrl) convertToJson() string {
    js, err := json.Marshal(rcv.file.Section("text/signup"))
    if err != nil {
        rcv.AddErr("ConvertError", err.Error())
        return ""
    }
    return string(js)
}

func (rcv *ctrl) serveHttp() (types.SuccsJSON, types.ErrorsJSON) {

    rcv.upload()
    if rcv.AnyErrors() {
        return nil, rcv.Errs
    }

    str := rcv.convertToJson()
    if rcv.AnyErrors() {
        return nil, rcv.Errs
    }
    return c.Sucss, nil
}

The method serveHttp() handle the response to client. As you can see, I am handling the error with the method AnyError() everytime. I find this way is pretty boring and maybe wrong design. Would it be better to throw a panic instead of error handling?

func (rcv *ctrl) upload() {
    file, err := ini.LoadFile(rcv.getFile())
    if err != nil {
        rcv.AddErr("TextError", err.Error())
        panic()
    }
    rcv.file = file
}
  • 写回答

1条回答 默认 最新

  • donglu5728 2015-02-11 12:45
    关注

    No, it would not be better. Checking your errors is not bad design in Go. Panicking when there is no reason to do so, on the other hand, is bad design, because it's harder to test and debug.

    The Go Wiki explicitly discourages the use of panic outside of truly exceptional cases, when the error is unrecoverable and state of the program can't be fixed.

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥15 远程桌面文档内容复制粘贴,格式会变化
  • ¥15 关于#java#的问题:找一份能快速看完mooc视频的代码
  • ¥15 这种微信登录授权 谁可以做啊
  • ¥15 请问我该如何添加自己的数据去运行蚁群算法代码
  • ¥20 用HslCommunication 连接欧姆龙 plc有时会连接失败。报异常为“未知错误”
  • ¥15 网络设备配置与管理这个该怎么弄
  • ¥20 机器学习能否像多层线性模型一样处理嵌套数据
  • ¥20 西门子S7-Graph,S7-300,梯形图
  • ¥50 用易语言http 访问不了网页
  • ¥50 safari浏览器fetch提交数据后数据丢失问题