我可以缩短这段代码吗？ [关闭]

Question

I have this code and i am so bad in PHP, could someone show me how to optimize this? i think the code could be shorter somehow?

I tried to put all the echo's in one line somehow but no luck ...

<?php
$metakey = 'evcal_srow';
$zeit = $wpdb->get_col($wpdb->prepare("SELECT DISTINCT meta_value FROM $wpdb->postmeta WHERE meta_key = %s ORDER BY meta_value ASC", $metakey) );
 if ($zeit) {
 foreach ($zeit as $evcal_srow) {
 echo "<div class='datum'>";
 echo gmdate("d.m.Y", $evcal_srow);
 echo "</div>";
 echo "<div class='uhrzeit'>";
 echo gmdate("H:i", $evcal_srow);
 echo "</div>";
 }
 }
?>

thx!

Answer 1

You can concentrate strings and only call one echo, as well as removing extra spaces. Less readable, but fewer lines.

<?php
$metakey = 'evcal_srow';
$zeit = $wpdb->get_col($wpdb->prepare("SELECT DISTINCT meta_value FROM $wpdb->postmeta WHERE meta_key = %s ORDER BY meta_value ASC", $metakey) );
 if ($zeit) {
 foreach ($zeit as $evcal_srow) {
 echo "<div class='datum'>";
 echo gmdate("d.m.Y", $evcal_srow);
 echo "</div>";
 echo "<div class='uhrzeit'>";
 echo gmdate("H:i", $evcal_srow);
 echo "</div>";
 }
 }
?>

becomes

<?php $metakey='evcal_srow'; $zeit=$wpdb->get_col($wpdb->prepare("SELECT DISTINCT meta_value FROM $wpdb->postmeta WHERE meta_key = %s ORDER BY meta_value ASC", $metakey));
if($zeit){foreach($zeit as $evcal_srow){
    echo "<div class='datum'>".gmdate("d.m.Y", $evcal_srow)."</div><div class='uhrzeit'>".gmdate("H:i", $evcal_srow)."</div>";
}} ?>