dongshi2458 2013-11-15 18:45
浏览 35
已采纳

如何让Factory Class在PHP中创建对象实例?

I have an XML file with many member entries, formatted like so:

<staff>
    <member>
        <name></name>
        <image></image>
        <title></title>
        <email></email>
        <phone></phone>
        <location></location>
        <info></info>
        <webTitle></webTitle>
        <webURL></webURL>
    </member>
</staff>

setup

I've created 2 PHP classes, DisplayStaff and Employee.

  • Employee creates an Employee object, with private properties outlined in the XML above.
  • DisplayStaff is a factory class. It loads the above XML file, iterates through it, creating an Employee instance for each <member> element in the XML. It stores the Employee object in an array, $Employees[].

On the page where I want to output the Employee information, I'd like to be able to reference it like so.

$Employees = new DisplayStaff();
$John = Employees['John'];
echo "Hello, my name is $John->name";

code

<?php
 class DisplayStaff
 {
    private var $staffList;
    private var $placeholderImg;
    private var $Employees; 

    public function __construct() {
        $staffList      = simplexml_load_file("../data/staff.xml");
        $placeholderImg = $staffList->placeholderImg;
        foreach ( $staffList->member as $member ) {
            $employee = formatEmployeeObj( $member );
            array_push( $Employees, $employee );
        }
        return $Employees;
     }

     private function formatEmployeeObj( $memberXML ) {
         $Employee = new Employee();

         $Employee->set( $name,      $memberXML->name );
         $Employee->set( $image,     $memberXML->image );
         $Employee->set( $title,     $memberXML->title );
         $Employee->set( $email,     $memberXML->email );
         $Employee->set( $phone,     $memberXML->phone );
         $Employee->set( $location,  $memberXML->location );
         $Employee->set( $info,      $memberXML->info );
         $Employee->set( $webTitle,  $memberXML->webTitle );
         $Employee->set( $webURL,    $memberXML->webURL );

         return $Employee;
     }
}
?>

<?php
class Employee
{

     private var $name     = "";
     private var $image    = "";
     private var $title    = "";
     private var $email    = "";
     private var $phone    = "";
     private var $location = "";
     private var $info     = "";
     private var $webTitle = "";
     private var $webURL   = "";

        public function get($propertyName) {
        if( property_exists($this, $propertyName) ) {
            return $this->$propertyName;
        }
            else{
                return null;
           }
    }

    public function set($propertyName, $propertyValue) {
        if( property_exists($this, $propertyName) ){
            $this->$propertyName = $propertyValue;
        }
    }
}

?>

problem

I can't seem to get this working. I'm new to working with classes. What do I need to change to have my classes behave how I desire them to?

Thank you in advanced for any help.

  • 写回答

2条回答 默认 最新

  • doq1969 2013-11-15 20:20
    关注
    1. Remove var from each of your class fields. That is redundant with public and also deprecated as of PHP5. More on this

    2. The constructor should not return anything. It will automatically return the object in question. Note, however, that there is no way of accessing any of the DisplayStaff fields since they are all private with no accessor functions. You could use the universal accessors like you do in Employee, but is there a reason for not simply using public fields?

    3. Any time you are referring to an method or property of an object within the class declaration, you need to use the $this keyword, i.e.

      public function __construct() {
        $this->staffList  = simplexml_load_file("staff.xml");
        $this->placeholderImg = $this->staffList->placeholderImg
        foreach ( $this->staffList->member as $member ) {
          $employee = $this->formatEmployeeObj( $member );
          array_push( $this->Employees, $employee );
        }
      //no need for a return
      }
      
    4. Your Employee property accessor method (Employee->get()) takes a string as the first parameter, i.e. 'name'. $name is an undefined variable so it won't work.

    5. You need to initialize your Employees array before you can push to it.

      private $Employees = array();
      
    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论
查看更多回答(1条)

报告相同问题?

悬赏问题

  • ¥15 为什么shp文件会有这种小方块?
  • ¥15 ecplise在连接数据库时显示加载驱动成功但是数据库连接失败
  • ¥15 visionmaster启动失败,提示为“机器不满足授权而被禁用”
  • ¥50 用logisim设计16位单时钟周期cpu
  • ¥15 IDEA中圈复杂度如何具体设置
  • ¥50 labview采集不了数据
  • ¥15 Multisim红外倒车雷达仿真中距离问题
  • ¥15 请上面代码做什么处理或什么混淆
  • ¥15 英雄联盟自定义房间置顶
  • ¥15 W5500网线插上无反应